elharo commented on code in PR #3261:
URL: https://github.com/apache/maven-surefire/pull/3261#discussion_r2837774398
##########
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java:
##########
@@ -134,7 +137,8 @@ public StatelessXmlReporter(
boolean phrasedClassName,
boolean phrasedMethodName,
boolean enableOutErrElements,
- boolean enablePropertiesElement) {
+ boolean enablePropertiesElement,
Review Comment:
why are you updating a deprecated method?
##########
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java:
##########
@@ -640,6 +653,10 @@ private static void showProperties(XMLWriter xmlWriter,
Map<String, String> syst
xmlWriter.endElement();
}
+ private static String toIsoInstant(long epochMillis) {
Review Comment:
feels a little too simple to justify a whole method. Possibly can inline this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
