elharo commented on code in PR #1490:
URL: https://github.com/apache/maven-site/pull/1490#discussion_r2651028720
##########
content/markdown/guides/introduction/introduction-to-profiles.md:
##########
@@ -106,7 +106,27 @@ This profile will automatically be active for all builds
unless another profile
Profiles can be automatically triggered based on the state of the build
environment.
These triggers are specified via an `<activation>` section in the profile.
The implicit profile activation only refers to the container profile (and not
to profiles in other modules with the same id).
-Here are some examples.
+
+_Note_: Before Maven 3.2.2 activation occurs when one or more of the specified
criteria have been met. When the first positive result is encountered,
processing stops and the profile is marked as active.
+Since Maven 3.2.2 activation occurs when all the specified criteria have been
met.
+
+##### Active by default
+
+Boolean flag which determines if the profile is active by default. Is `false`
by default.
+This flag is only evaluated if no other profile is explicitly activated via
command line, `settings.xml` or implicitly activated through some other
activator, otherwise it has no effect.
Review Comment:
activator. Otherwise it has no effect.
or implicitly activated --> , or activated
##########
content/markdown/guides/introduction/introduction-to-profiles.md:
##########
@@ -106,7 +106,27 @@ This profile will automatically be active for all builds
unless another profile
Profiles can be automatically triggered based on the state of the build
environment.
These triggers are specified via an `<activation>` section in the profile.
The implicit profile activation only refers to the container profile (and not
to profiles in other modules with the same id).
-Here are some examples.
+
+_Note_: Before Maven 3.2.2 activation occurs when one or more of the specified
criteria have been met. When the first positive result is encountered,
processing stops and the profile is marked as active.
Review Comment:
In 2025 I think we can stop talking about what happens pre-3.2.2
##########
content/markdown/guides/introduction/introduction-to-profiles.md:
##########
@@ -136,7 +157,24 @@ The following configuration will trigger the profile when
the JDK's version _sta
</profiles>
```
-_Note:_ an upper bound such as `,1.5]` is likely not to include most releases
of 1.5, since they will have an additional "patch" release such as `_05` that
is not taken into consideration in the above range.
+_Note:_ The value ranges match if the JDK version used for running Maven is
between lower and upper bounds (either inclusive or exclusive).
+An upper bound such as `,1.5]` is likely not to include most releases of 1.5,
since they will have an additional "patch" release such as `_05` that is not
taken into consideration in the above range.
Review Comment:
is likely not to include --> likely does not include
##########
content/markdown/guides/introduction/introduction-to-profiles.md:
##########
@@ -136,7 +157,24 @@ The following configuration will trigger the profile when
the JDK's version _sta
</profiles>
```
-_Note:_ an upper bound such as `,1.5]` is likely not to include most releases
of 1.5, since they will have an additional "patch" release such as `_05` that
is not taken into consideration in the above range.
+_Note:_ The value ranges match if the JDK version used for running Maven is
between lower and upper bounds (either inclusive or exclusive).
+An upper bound such as `,1.5]` is likely not to include most releases of 1.5,
since they will have an additional "patch" release such as `_05` that is not
taken into consideration in the above range.
+
+If the range does not start with `[` or `(`, the value is interpreted as a
(vendor) prefix.
Review Comment:
do we need the parentheses around vendor?
##########
content/markdown/guides/introduction/introduction-to-profiles.md:
##########
@@ -136,7 +157,24 @@ The following configuration will trigger the profile when
the JDK's version _sta
</profiles>
```
-_Note:_ an upper bound such as `,1.5]` is likely not to include most releases
of 1.5, since they will have an additional "patch" release such as `_05` that
is not taken into consideration in the above range.
+_Note:_ The value ranges match if the JDK version used for running Maven is
between lower and upper bounds (either inclusive or exclusive).
Review Comment:
the lower
##########
content/markdown/guides/introduction/introduction-to-profiles.md:
##########
@@ -165,8 +203,16 @@ Each value can be prefixed with `!` to negate the
matching. The values match if
Since [Maven 3.9.7](https://issues.apache.org/jira/browse/MNG-5726) the value
for `version` may be prefixed with `regex:`. In that case [regular pattern
matching](https://docs.oracle.com/javase/tutorial/essential/regex/) is applied
for the version matching and applied against the **lower case** `os.version`
value.
The actual OS values which need to match the given values are emitted when
executing `mvn --version`.
+See the maven-enforcer-plugin's [Require OS
Rule](/enforcer/enforcer-rules/requireOS.html) for more details about OS values.
Review Comment:
might be better as an absolute URL in case this site is mirrored somewhere
##########
content/markdown/guides/introduction/introduction-to-profiles.md:
##########
@@ -290,6 +336,9 @@ Since Maven 3.9.0 one can also evaluate the POM's packaging
value by referencing
##### Files
+A given filename may activate the `profile` by the `existence` of a file, or
if it is `missing`.
+**NOTE**: Interpolation for this element is limited to `${project.basedir}`,
System properties and request properties.
Review Comment:
comma in "properties, and"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
