[ 
https://issues.apache.org/jira/browse/SCM-943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17963783#comment-17963783
 ] 

ASF GitHub Bot commented on SCM-943:
------------------------------------

jira-importer opened a new issue, #1179:
URL: https://github.com/apache/maven-scm/issues/1179

   **[Michiel 
Kalkman](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=michielgkalkman)**
 opened 
**[SCM-943](https://issues.apache.org/jira/browse/SCM-943?redirect=false)** and 
commented
   
   It seems like scm:check-local-modification does not support the excludes and 
includes parameters. Which is annoying, because I want to exclude *.iml from 
Intellij from this check.
   
   Looking (but not yet testing) at CheckLocalModificationsMojo::execute(), it 
does:
   
   ```java
   result = getScmManager().status( repository, new ScmFileSet( baseDirectory ) 
);
   ```
   
   So it does not address neither includes, nor excludes parameter.
   
   My first though would be that something like this is the start of fix:
   
   ```java
   result = getScmManager().status( repository, new ScmFileSet( 
getWorkingDirectory(), getIncludes(), getExcludes() ) );
   ```
   
   Is this something that has not yet been implemented, or is there a user 
error on my part?
    
   
   
   ---
   
   **Remote Links:**
   - [GitHub Pull Request #139
   ](https://github.com/apache/maven-scm/pull/139)
   




> scm:check-local-modification does not support excludes
> ------------------------------------------------------
>
>                 Key: SCM-943
>                 URL: https://issues.apache.org/jira/browse/SCM-943
>             Project: Maven SCM (Moved to GitHub Issues)
>          Issue Type: Improvement
>            Reporter: Michiel Kalkman
>            Assignee: Michael Osipov
>            Priority: Major
>             Fix For: 1.13.0, 2.0.0-M2
>
>
> It seems like scm:check-local-modification does not support the excludes and 
> includes parameters. Which is annoying, because I want to exclude *.iml from 
> Intellij from this check.
> Looking (but not yet testing) at CheckLocalModificationsMojo::execute(), it 
> does:
> {code:java}
> result = getScmManager().status( repository, new ScmFileSet( baseDirectory ) 
> );
> {code}
> So it does not address neither includes, nor excludes parameter.
> My first though would be that something like this is the start of fix:
> {code:java}
> result = getScmManager().status( repository, new ScmFileSet( 
> getWorkingDirectory(), getIncludes(), getExcludes() ) );
> {code}
> Is this something that has not yet been implemented, or is there a user error 
> on my part?
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to