Pankraz76 commented on code in PR #2370:
URL: https://github.com/apache/maven/pull/2370#discussion_r2104394597


##########
its/core-it-support/core-it-plugins/maven-it-plugin-active-collection/src/main/java/org/apache/maven/plugin/coreit/CheckThreadSafetyMojo.java:
##########
@@ -95,7 +95,10 @@ public void run() {
                     getLog().info("[MAVEN-CORE-IT-LOG] Thread " + this + " 
uses " + tccl);
                     Thread.currentThread().setContextClassLoader(tccl);
                     while (go.isEmpty()) {
-                        // wait for start
+                        try {
+                            Thread.sleep(100); // wait for the start
+                        } catch (InterruptedException ignored) {

Review Comment:
   > Empty blocks are illegal wrt checkstyle.
   
   if this is true then this whole PR would not be possible as the root cause 
is 
https://pmd.github.io/pmd/pmd_rules_java_codestyle.html#emptycontrolstatement.
   
   ![Uploading image.png…]()
   
   
   [INFO] BUILD SUCCESS
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to