Pankraz76 commented on code in PR #2370:
URL: https://github.com/apache/maven/pull/2370#discussion_r2104384665


##########
its/core-it-support/core-it-plugins/maven-it-plugin-active-collection/src/main/java/org/apache/maven/plugin/coreit/CheckThreadSafetyMojo.java:
##########
@@ -95,7 +95,10 @@ public void run() {
                     getLog().info("[MAVEN-CORE-IT-LOG] Thread " + this + " 
uses " + tccl);
                     Thread.currentThread().setContextClassLoader(tccl);
                     while (go.isEmpty()) {
-                        // wait for start
+                        try {
+                            Thread.sleep(100); // wait for the start
+                        } catch (InterruptedException ignored) {

Review Comment:
   yes this rules must be absent or bug. As we have this several times i assume 
its misconfigured.
   
   - https://checkstyle.sourceforge.io/checks/blocks/emptyblock.html
   - 
https://github.com/apache/maven-shared-resources/blob/bad8df9df24313a66dd5968194b631305ac499dd/src/main/resources/config/maven_checks_nocodestyle.xml#L106
   - so its a bug. Again one reason to chain the tools.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to