gnodet commented on code in PR #2367:
URL: https://github.com/apache/maven/pull/2367#discussion_r2100674339
##########
compat/maven-compat/src/test/java/org/apache/maven/repository/legacy/resolver/DefaultArtifactCollectorTest.java:
##########
@@ -293,10 +293,9 @@ void testResolveNearestWithRanges() throws
ArtifactResolutionException, InvalidV
}
@Test
- @SuppressWarnings("checkstyle:UnusedLocalVariable")
void testResolveRangeWithManagedVersion() throws
ArtifactResolutionException, InvalidVersionSpecificationException {
ArtifactSpec a = createArtifactSpec("a", "1.0");
- ArtifactSpec b = a.addDependency("b", "[1.0,3.0]");
Review Comment:
Yes , adding an assertNotNull should do the trick.
##########
compat/maven-compat/src/test/java/org/apache/maven/repository/legacy/resolver/DefaultArtifactCollectorTest.java:
##########
@@ -293,10 +293,9 @@ void testResolveNearestWithRanges() throws
ArtifactResolutionException, InvalidV
}
@Test
- @SuppressWarnings("checkstyle:UnusedLocalVariable")
void testResolveRangeWithManagedVersion() throws
ArtifactResolutionException, InvalidVersionSpecificationException {
ArtifactSpec a = createArtifactSpec("a", "1.0");
- ArtifactSpec b = a.addDependency("b", "[1.0,3.0]");
Review Comment:
Yes , adding an assertNotNull should do the trick.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
