[
https://issues.apache.org/jira/browse/MNG-6829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17721029#comment-17721029
]
ASF GitHub Bot commented on MNG-6829:
-------------------------------------
elharo commented on code in PR #185:
URL: https://github.com/apache/maven-release/pull/185#discussion_r1188960087
##########
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/RunPerformGoalsPhase.java:
##########
@@ -79,7 +79,7 @@ private ReleaseResult runLogic(
// ensure we don't use the release pom for the perform goals
// ^^ paranoia? A MavenExecutor has already access to this. Probably
worth refactoring.
- if (!StringUtils.isEmpty(additionalArguments)) {
+ if (!(additionalArguments == null || additionalArguments.isEmpty())) {
Review Comment:
The recipe could be updated to rewrite this one as
```
additionalArguments != null && !additionalArguments.isEmpty()
```
> Remove commons-lang3 dependency
> -------------------------------
>
> Key: MNG-6829
> URL: https://issues.apache.org/jira/browse/MNG-6829
> Project: Maven
> Issue Type: Sub-task
> Components: Bootstrap & Build
> Affects Versions: 3.6.3
> Reporter: Karl Heinz Marbaise
> Assignee: Karl Heinz Marbaise
> Priority: Minor
> Labels: close-pending
> Fix For: 4.0.x-candidate
>
> Attachments: dtPKn.xlsx
>
>
> Currently we use {{commons-lang3}} for the following classes
> * {{StringUtils}} can be replaced by usage of either {{plexus-utils}} or
> {{maven-shared-utils}} or as I tested with self implementation
> * {{SystemUtils}} is only used in some tests which can simply replaced by
> using JUnit Jupiter with all the support it has.
> * {{Validate}} is a precondition class which checks for parameters etc. can
> be implemented very easily (done already to see how it works). Later this
> could be made part of {{maven-shared-utils}}.
> * Currently the {{StringUtils.substringAfterLast( resourceName, "/" )}} is
> used in {{ConsoleMavenTransferListener}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
