[
https://issues.apache.org/jira/browse/MNG-6829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17720679#comment-17720679
]
ASF GitHub Bot commented on MNG-6829:
-------------------------------------
timtebeek commented on PR #124:
URL: https://github.com/apache/maven-pmd-plugin/pull/124#issuecomment-1539062036
> In fact, now that I think about it, we should pause these changes until
Moderne does sign the corporate CLA. An Individual CLA is insufficient given
the co-authorship line.
@elharo I'm pleased to say we've finally been able to sign (and get
accepted) the CCLA:
> This message acknowledges receipt of the following document, which has
been filed in the Apache Software Foundation records:
> CCLA from Moderne Inc.
Would you want me to resume creating pull requests to replace
`StringUtils#is/Not/Empty(String)` as we've done here?
I was thinking to open up to ten at a time, and only start a next batch when
there's less than five open; does that sound OK?
The changes would be made by running this recipe against the Apache Maven
organization defined in the top right corner:
https://public.moderne.io/recipes/org.openrewrite.java.migrate.apache.commons.lang.IsNotEmptyToJdk
You're more than welcome to have a look as well; shouldn't take more than a
couple minutes to create a few PRs or direct commits.
> Remove commons-lang3 dependency
> -------------------------------
>
> Key: MNG-6829
> URL: https://issues.apache.org/jira/browse/MNG-6829
> Project: Maven
> Issue Type: Sub-task
> Components: Bootstrap & Build
> Affects Versions: 3.6.3
> Reporter: Karl Heinz Marbaise
> Assignee: Karl Heinz Marbaise
> Priority: Minor
> Labels: close-pending
> Fix For: 4.0.x-candidate
>
> Attachments: dtPKn.xlsx
>
>
> Currently we use {{commons-lang3}} for the following classes
> * {{StringUtils}} can be replaced by usage of either {{plexus-utils}} or
> {{maven-shared-utils}} or as I tested with self implementation
> * {{SystemUtils}} is only used in some tests which can simply replaced by
> using JUnit Jupiter with all the support it has.
> * {{Validate}} is a precondition class which checks for parameters etc. can
> be implemented very easily (done already to see how it works). Later this
> could be made part of {{maven-shared-utils}}.
> * Currently the {{StringUtils.substringAfterLast( resourceName, "/" )}} is
> used in {{ConsoleMavenTransferListener}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
