AlexanderAshitkin commented on code in PR #69:
URL:
https://github.com/apache/maven-build-cache-extension/pull/69#discussion_r1169467126
##########
src/main/java/org/apache/maven/buildcache/checksum/MavenProjectInput.java:
##########
@@ -667,8 +663,11 @@ private SortedMap<String, String> getMutableDependencies()
throws IOException {
String projectHash;
if (dependencyProject != null) // part of multi module
{
- projectHash =
-
projectInputCalculator.calculateInput(dependencyProject).getChecksum();
+ // To avoid the current module (B) to be re-built if it
depends on a module (A) of the current project
+ // which has some of its files edited.
+ // It would have no sense to re-build module B just because
module A was edited.
+ // More info:
https://issues.apache.org/jira/projects/MBUILDCACHE/issues/MBUILDCACHE-54
+ continue;
Review Comment:
This is wrong - please see the jira comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
