[
https://issues.apache.org/jira/browse/MNG-6825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17708807#comment-17708807
]
ASF GitHub Bot commented on MNG-6825:
-------------------------------------
timtebeek commented on PR #1080:
URL: https://github.com/apache/maven/pull/1080#issuecomment-1497290936
Great to see these changes! I think the `is(Not)Empty` cases to move away
from utils can also be reflected in an automated migration if you'd like me to
roll that out across all of Maven. I think that was the most common use of
utils.
Other cases that came up in discussion elsewhere are not as clear in the
general case, but can be automated in specific cases. For instance the utils
`split` methods take a separator as a literal, rather than the regex it can be
for `String.split`. We can explore what we can replace with JDK calls already,
now, and I'll hold off on further Commons Lang changes while we do so.
I'm traveling this week, so can't fully dive in, but hope to revisit the
automations next week. Let me know if there's any over replacements that you'd
like to distill from this one. Only looking to help & amplify changes such as
this PR.
> Cleaning Up dependencies
> plexus-utils/maven-shared-utils/commons-lang3/commons-io
> ---------------------------------------------------------------------------------
>
> Key: MNG-6825
> URL: https://issues.apache.org/jira/browse/MNG-6825
> Project: Maven
> Issue Type: Improvement
> Components: Bootstrap & Build
> Affects Versions: 3.6.3
> Reporter: Karl Heinz Marbaise
> Assignee: Karl Heinz Marbaise
> Priority: Minor
> Fix For: 4.0.x-candidate
>
>
> Experiment to see if we can get rid of commons-lang3 dependency.
> * Identified code duplication between:
> ** {{org.apache.commons.lang3.StringUtils}} from {{commons-lang3}} (501879
> Bytes commons-lang3-3.8.1.jar)
> ** {{org.codehaus.plexus.util.StringUtil}} from {{plexus-utils}} (261801
> Bytes plexus-utils-3.2.1.jar)
> ** {{org.apache.maven.shared.utils}} from {{maven-shared-utils}} (166562
> Bytes maven-shared-utils-3.2.1.jar)
> ** We should replace the self implemented with
> {{org.codehaus.plexus.util.StringUtil}}. or with {{maven-shared-utils}}
> * {{commons-io}} usage by {{maven-shared-utils}} (208700 Bytes
> commons-io-2.5.jar)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
