[jira] [Commented] (MNG-6825) Cleaning Up dependencies plexus-utils/maven-shared-utils/commons-lang3/commons-io

[ASF GitHub Bot (Jira)]

    [ 
https://issues.apache.org/jira/browse/MNG-6825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17708605#comment-17708605
 ] 

ASF GitHub Bot commented on MNG-6825:
-------------------------------------

elharo commented on code in PR #1080:
URL: https://github.com/apache/maven/pull/1080#discussion_r1157809106


##########
maven-embedder/src/test/java/org/apache/maven/cli/MavenCliTest.java:
##########
@@ -158,7 +158,7 @@ public void testCalculateDegreeOfConcurrency() {
         int cpus = Runtime.getRuntime().availableProcessors();
         assertEquals((int) (cpus * 2.2), 
cli.calculateDegreeOfConcurrency("2.2C"));
         assertEquals(1, cli.calculateDegreeOfConcurrency("0.0001C"));
-        assertThrows(IllegalArgumentException.class, () -> 
cli.calculateDegreeOfConcurrency("2.C"));
+        assertThrows(IllegalArgumentException.class, () -> 
cli.calculateDegreeOfConcurrency("2.xC"));

Review Comment:
   OK, so it's an extra test. That's fine, but I suggest also keeping 
   
   ```
   assertThrows(IllegalArgumentException.class, () -> 
cli.calculateDegreeOfConcurrency("2.C"));
   ```



##########
maven-artifact/src/main/java/org/apache/maven/artifact/ArtifactUtils.java:
##########
@@ -89,10 +88,15 @@ public static String key(String groupId, String artifactId, 
String version) {
     }
 
     private static void notBlank(String str, String message) {
-        int c = str != null && str.length() > 0 ? str.charAt(0) : 0;
-        if ((c < '0' || c > '9') && (c < 'a' || c > 'z')) {
-            Validate.notBlank(str, message);
+        final int strLen = str != null ? str.length() : 0;

Review Comment:
   I was simply thinking
   
   ```
   if (str != null && !str.isEmpty())
   ```
   
   but this works too. Not a big deal. 





> Cleaning Up dependencies 
> plexus-utils/maven-shared-utils/commons-lang3/commons-io
> ---------------------------------------------------------------------------------
>
>                 Key: MNG-6825
>                 URL: https://issues.apache.org/jira/browse/MNG-6825
>             Project: Maven
>          Issue Type: Improvement
>          Components: Bootstrap &amp; Build
>    Affects Versions: 3.6.3
>            Reporter: Karl Heinz Marbaise
>            Assignee: Karl Heinz Marbaise
>            Priority: Minor
>             Fix For: 4.0.x-candidate
>
>
> Experiment to see if we can get rid of commons-lang3 dependency.
> * Identified code duplication between:
> ** {{org.apache.commons.lang3.StringUtils}} from {{commons-lang3}} (501879 
> Bytes commons-lang3-3.8.1.jar)
> ** {{org.codehaus.plexus.util.StringUtil}} from {{plexus-utils}} (261801 
> Bytes plexus-utils-3.2.1.jar)
> ** {{org.apache.maven.shared.utils}} from {{maven-shared-utils}} (166562 
> Bytes maven-shared-utils-3.2.1.jar)
> ** We should replace the self implemented with 
> {{org.codehaus.plexus.util.StringUtil}}. or with {{maven-shared-utils}}
> * {{commons-io}} usage by {{maven-shared-utils}} (208700 Bytes 
> commons-io-2.5.jar)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)