uschindler commented on code in PR #14651:
URL: https://github.com/apache/lucene/pull/14651#discussion_r2086578233
##########
gradle/validation/ecj-lint.gradle:
##########
@@ -94,10 +96,10 @@ allprojects {
args += [ "-d", "none" ]
+ assert project.java.sourceCompatibility ==
project.java.targetCompatibility
+
// Compilation environment.
- // we use -source/-target as it is significantly faster than --release
- args += [ "-source", project.java.sourceCompatibility ]
- args += [ "-target", project.java.targetCompatibility ]
+ args += ["-$project.java.sourceCompatibility"] // "compliance" level
Review Comment:
Man man. The change here is only cleanup. There is no need to change any
files. The removal of the properties in the properties file passed to compiler
are unrelated to that change we're talking about here. It was already fixed by
my commit.
The change here is..... ONLY COSMETIC. It does not change anything in
functionality. So we can leave it out. Please stop arguing. This is annoying to
me. Sorry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
