uschindler commented on code in PR #14651:
URL: https://github.com/apache/lucene/pull/14651#discussion_r2086555819
##########
gradle/validation/ecj-lint.gradle:
##########
@@ -94,10 +96,10 @@ allprojects {
args += [ "-d", "none" ]
+ assert project.java.sourceCompatibility ==
project.java.targetCompatibility
+
// Compilation environment.
- // we use -source/-target as it is significantly faster than --release
- args += [ "-source", project.java.sourceCompatibility ]
- args += [ "-target", project.java.targetCompatibility ]
+ args += ["-$project.java.sourceCompatibility"] // "compliance" level
Review Comment:
We already agreed to keep the command line options as is. I just want you to
calm down and argue about something we agreed several times.
Sometimes you can do a cleanup or not, what @dsmiley dis was just to replace
a command line flag to make the command line shorter.
Actually puting target and source on the command line will set compliance
level, too. So it won't need to be included in the config file. It was always
obsolete and was only included for the Eclipse config. So see this two lines
just as a cleanup. We can argue several months about it, but I would no longer
listen to you. Sorry. Complete nonsense!
Therefore I added a commit yesterday to set the compliance level and
source/target level in the eclipse configuration. The ECJ linter uses the
property from command line, which is cheaper to do than patching a file (I
don't want to create random temp files for nonsense as sthis slows down on
Windows!).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
