thecoop commented on code in PR #14510:
URL: https://github.com/apache/lucene/pull/14510#discussion_r2071728838
##########
lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene101/Lucene101PostingsReader.java:
##########
@@ -149,9 +150,9 @@ public Lucene101PostingsReader(SegmentReadState state)
throws IOException {
IndexFileNames.segmentFileName(
state.segmentInfo.name, state.segmentSuffix,
Lucene101PostingsFormat.DOC_EXTENSION);
try {
- // Postings have a forward-only access pattern, so pass
ReadAdvice.NORMAL to perform
- // readahead.
- docIn = state.directory.openInput(docName,
state.context.withReadAdvice(ReadAdvice.NORMAL));
+ docIn =
+ state.directory.openInput(
+ docName, state.context.withHints(FileTypeHint.DATA,
FileDataHint.POSTINGS));
Review Comment:
This doesn't set a DataAccessHint as it's not RANDOM or SEQUENTIAL, just
NORMAL.
I've tried to keep the initial hints as simple as possible here, without
changing behaviour, so we can normalise and possibly modify behaviour in a
subsequent PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
