thecoop commented on code in PR #14510:
URL: https://github.com/apache/lucene/pull/14510#discussion_r2068656440
##########
lucene/test-framework/src/java/org/apache/lucene/tests/store/SerialIOCountingDirectory.java:
##########
@@ -72,7 +72,7 @@ public ChecksumIndexInput openChecksumInput(String name)
throws IOException {
@Override
public IndexInput openInput(String name, IOContext context) throws
IOException {
- ReadAdvice readAdvice =
context.readAdvice().orElse(Constants.DEFAULT_READADVICE);
+ ReadAdvice readAdvice = MMapDirectory.toReadAdvice(context);
Review Comment:
This is not great - SerialIOCountingDirectory needs to know about the
specific ReadAdvice to record the reads the OS *should* make with that
ReadAdvice. But,
https://github.com/apache/lucene/pull/14593#issuecomment-2841419541, do we
actually need these tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
