kaivalnp commented on code in PR #13285:
URL: https://github.com/apache/lucene/pull/13285#discussion_r1689584585
##########
lucene/core/src/java/org/apache/lucene/search/AbstractVectorSimilarityQuery.java:
##########
@@ -103,16 +114,18 @@ public Explanation explain(LeafReaderContext context, int
doc) throws IOExceptio
public ScorerSupplier scorerSupplier(LeafReaderContext context) throws
IOException {
LeafReader leafReader = context.reader();
Bits liveDocs = leafReader.getLiveDocs();
- final Scorer vectorSimilarityScorer;
+
+ QueryTimeout queryTimeout = searcher.getTimeout();
+ TimeLimitingKnnCollectorManager timeLimitingKnnCollectorManager =
Review Comment:
Nice catch, we can reduce unnecessary object creation. I'll update in the
next commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
