gsmiller commented on code in PR #12862:
URL: https://github.com/apache/lucene/pull/12862#discussion_r1539340494
##########
lucene/facet/src/java/org/apache/lucene/facet/Facets.java:
##########
@@ -58,6 +58,9 @@ public abstract FacetResult getTopChildren(int topN, String
dim, String... path)
/**
* Return the counts or values for specific paths. Returns {@link
#MISSING_SPECIFIC_VALUE} if
* corresponding path doesn't exist, else the count.
+ *
+ * <p>{@link #getSpecificValue} for each path should produce similar
results, but the bulk method
Review Comment:
Can we make this stronger? It should produce identical results right (not
"similar")? Or maybe that's not true?
##########
lucene/CHANGES.txt:
##########
@@ -87,6 +87,10 @@ API Changes
* GITHUB#13146, GITHUB#13148: Remove ByteBufferIndexInput and only use
MemorySegment APIs
for MMapDirectory. (Uwe Schindler)
+* GITHUB#12919: Add Facets#getBulkSpecificValues method to get specific values
for multiple FacetLabels at once. (Egor Potemkin)
+
+* GITHUB#12919: Add Facets#getBulkSpecificValues method to get specific values
for multiple FacetLabels at once. (Egor Potemkin)
Review Comment:
I know it's a big change but we probably don't need double changes entries ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
