mapleFU commented on code in PR #3194:
URL: https://github.com/apache/kvrocks/pull/3194#discussion_r2365599547
##########
src/storage/redis_db.h:
##########
@@ -155,7 +155,6 @@ class Database {
private:
// Already internal keys
- [[nodiscard]] rocksdb::Status existsInternal(engine::Context &ctx, const
std::vector<std::string> &keys, int *ret);
Review Comment:
I'm so sorry to comment this again and again. But why not:
```
[[nodiscard]] rocksdb::Status existsInternal(engine::Context &ctx, const
nonstd::span<Slice> &keys, int *ret) {
// From benchmark, ...
if (keys.size() == 1) {
// Get..
} else {
// MultiGet
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
