cyningsun commented on code in PR #3194:
URL: https://github.com/apache/kvrocks/pull/3194#discussion_r2365379949
##########
src/storage/redis_db.cc:
##########
@@ -208,12 +208,39 @@ rocksdb::Status Database::MDel(engine::Context &ctx,
const std::vector<Slice> &k
}
rocksdb::Status Database::Exists(engine::Context &ctx, const
std::vector<Slice> &keys, int *ret) {
+ *ret = 0;
+
+ if (keys.empty()) {
+ return rocksdb::Status::OK();
+ }
+
std::vector<std::string> ns_keys;
+ std::vector<Slice> slice_keys;
ns_keys.reserve(keys.size());
+ slice_keys.reserve(keys.size());
+
for (const auto &key : keys) {
ns_keys.emplace_back(AppendNamespacePrefix(key));
+ slice_keys.emplace_back(ns_keys.back());
+ }
+
+ std::vector<rocksdb::Status> statuses(slice_keys.size());
+ std::vector<rocksdb::PinnableSlice> pin_values(slice_keys.size());
+ storage_->MultiGet(ctx, ctx.DefaultMultiGetOptions(), metadata_cf_handle_,
slice_keys.size(), slice_keys.data(),
+ pin_values.data(), statuses.data());
+
+ for (size_t i = 0; i < slice_keys.size(); i++) {
+ if (!statuses[i].ok() && !statuses[i].IsNotFound()) return statuses[i];
+ if (statuses[i].ok()) {
+ Metadata metadata(kRedisNone, false);
+ // Explicit construct a rocksdb::Slice to avoid the implicit conversion
from
+ // PinnableSlice to Slice.
Review Comment:
comment is moved from caller to function declaration
##########
src/storage/redis_db.cc:
##########
@@ -208,12 +208,39 @@ rocksdb::Status Database::MDel(engine::Context &ctx,
const std::vector<Slice> &k
}
rocksdb::Status Database::Exists(engine::Context &ctx, const
std::vector<Slice> &keys, int *ret) {
+ *ret = 0;
+
+ if (keys.empty()) {
+ return rocksdb::Status::OK();
+ }
+
std::vector<std::string> ns_keys;
+ std::vector<Slice> slice_keys;
ns_keys.reserve(keys.size());
+ slice_keys.reserve(keys.size());
+
for (const auto &key : keys) {
ns_keys.emplace_back(AppendNamespacePrefix(key));
+ slice_keys.emplace_back(ns_keys.back());
+ }
+
+ std::vector<rocksdb::Status> statuses(slice_keys.size());
+ std::vector<rocksdb::PinnableSlice> pin_values(slice_keys.size());
+ storage_->MultiGet(ctx, ctx.DefaultMultiGetOptions(), metadata_cf_handle_,
slice_keys.size(), slice_keys.data(),
+ pin_values.data(), statuses.data());
+
+ for (size_t i = 0; i < slice_keys.size(); i++) {
+ if (!statuses[i].ok() && !statuses[i].IsNotFound()) return statuses[i];
+ if (statuses[i].ok()) {
+ Metadata metadata(kRedisNone, false);
+ // Explicit construct a rocksdb::Slice to avoid the implicit conversion
from
+ // PinnableSlice to Slice.
Review Comment:
Comment is moved from caller to function declaration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
