greatsharp commented on code in PR #3077:
URL: https://github.com/apache/kvrocks/pull/3077#discussion_r2361902347
##########
src/cluster/batch_sender.cc:
##########
@@ -100,7 +100,7 @@ Status BatchSender::sendApplyBatchCmd(int fd, const
rocksdb::WriteBatch &write_b
GET_OR_RET(util::SockSend(fd, redis::ArrayOfBulkStrings({"APPLYBATCH",
write_batch.Data()})));
- std::string line = GET_OR_RET(util::SockReadLine(fd));
+ std::string line = GET_OR_RET(util::SockReadLineWithRetry(fd, 10, 500));
Review Comment:
> I am confused here. I think the fd here is made by `util:SockConnect`.
From the code, it does looks like `SockConnect` returns a blocking fd. Am I
missing anything?
agree with you， so we just used the util::SockReadLineWithRetry(fd, 10, 500)
to resolve this problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
