PragmaTwice commented on code in PR #3077:
URL: https://github.com/apache/kvrocks/pull/3077#discussion_r2251006591
##########
src/cluster/batch_sender.cc:
##########
@@ -100,7 +100,7 @@ Status BatchSender::sendApplyBatchCmd(int fd, const
rocksdb::WriteBatch &write_b
GET_OR_RET(util::SockSend(fd, redis::ArrayOfBulkStrings({"APPLYBATCH",
write_batch.Data()})));
- std::string line = GET_OR_RET(util::SockReadLine(fd));
+ std::string line = GET_OR_RET(util::SockReadLineWithRetry(fd, 10, 500));
Review Comment:
In non-blocking IO, it's quite normal to receive a EAGAIN or EWOULDBLOCK to
indicate that currently there's no data to retrieve from the stream.
In such case, if we just make it a busy retry loop (or with a sleep), we are
actually converting it to a blocking socket.
And IMHO it seems not a good method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
