LindaSummer commented on code in PR #3163:
URL: https://github.com/apache/kvrocks/pull/3163#discussion_r2335959183
##########
src/commands/cmd_tdigest.cc:
##########
@@ -371,5 +415,6 @@ REDIS_REGISTER_COMMANDS(TDigest,
MakeCmdAttr<CommandTDigestCreate>("tdigest.crea
MakeCmdAttr<CommandTDigestMin>("tdigest.min", 2,
"read-only", 1, 1, 1),
MakeCmdAttr<CommandTDigestQuantile>("tdigest.quantile", -3, "read-only", 1, 1,
1),
MakeCmdAttr<CommandTDigestReset>("tdigest.reset", 2,
"write", 1, 1, 1),
- MakeCmdAttr<CommandTDigestMerge>("tdigest.merge", -4,
"write", GetMergeKeyRange));
+ MakeCmdAttr<CommandTDigestMerge>("tdigest.merge", -4,
"write", GetMergeKeyRange),
+ MakeCmdAttr<CommandTDigestCDF>("tdigest.cdf", -4,
"write", 1, 1, 1));
Review Comment:
You can refer to PR #2620 for further understanding of the `MakeCmdAttr`
flags.
https://github.com/apache/kvrocks/blob/cf28ab1c451c4788d782f2c4b178934bd0210cf0/src/server/redis_connection.cc#L528-L546
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
