LindaSummer commented on code in PR #3163:
URL: https://github.com/apache/kvrocks/pull/3163#discussion_r2333953913
##########
src/commands/cmd_tdigest.cc:
##########
@@ -358,7 +358,51 @@ class CommandTDigestMerge : public Commander {
std::vector<std::string> source_keys_;
TDigestMergeOptions options_;
};
+class CommandTDigestCDF : public Commander {
+ Status Parse(const std::vector<std::string> &args) override {
+ key_name_ = args[1];
+ if (args.size() == 2) return {Status::RedisParseErr,
errWrongNumOfArguments};
+ values_.reserve(args.size() - 2);
+ for (size_t i = 2; i < args.size(); i++) {
+ auto value = ParseFloat(args[i]);
+ if (!value) {
+ return {Status::RedisParseErr, errValueIsNotFloat};
+ }
+ values_.push_back(*value);
+ }
+ return Status::OK();
+ }
+ Status Execute(engine::Context &ctx, Server *srv, Connection *conn,
std::string *output) override {
+ TDigest tdigest(srv->storage, conn->GetNamespace());
+ std::vector<std::string> cdf_result;
+ TDigestCDFResult result;
+ TDigestMetadata metadata;
+ auto meta_status = tdigest.GetMetaData(ctx, key_name_, &metadata);
+ if (!meta_status.ok()) {
+ if (meta_status.IsNotFound()) {
+ return {Status::RedisExecErr, errKeyNotFound};
+ }
+ return {Status::RedisExecErr, meta_status.ToString()};
+ }
+ if (metadata.total_observations == 0) {
Review Comment:
I have tested with Redis Docker, it should be the ["nan"] vector with the
same size as the input.
##########
src/commands/cmd_tdigest.cc:
##########
@@ -371,5 +415,6 @@ REDIS_REGISTER_COMMANDS(TDigest,
MakeCmdAttr<CommandTDigestCreate>("tdigest.crea
MakeCmdAttr<CommandTDigestMin>("tdigest.min", 2,
"read-only", 1, 1, 1),
MakeCmdAttr<CommandTDigestQuantile>("tdigest.quantile", -3, "read-only", 1, 1,
1),
MakeCmdAttr<CommandTDigestReset>("tdigest.reset", 2,
"write", 1, 1, 1),
- MakeCmdAttr<CommandTDigestMerge>("tdigest.merge", -4,
"write", GetMergeKeyRange));
+ MakeCmdAttr<CommandTDigestMerge>("tdigest.merge", -4,
"write", GetMergeKeyRange),
+ MakeCmdAttr<CommandTDigestCDF>("tdigest.cdf", -4,
"write", 1, 1, 1));
Review Comment:
It is a read-only command, but with a lock guard in merge action.
##########
src/commands/cmd_tdigest.cc:
##########
@@ -358,7 +358,51 @@ class CommandTDigestMerge : public Commander {
std::vector<std::string> source_keys_;
TDigestMergeOptions options_;
};
+class CommandTDigestCDF : public Commander {
+ Status Parse(const std::vector<std::string> &args) override {
+ key_name_ = args[1];
+ if (args.size() == 2) return {Status::RedisParseErr,
errWrongNumOfArguments};
+ values_.reserve(args.size() - 2);
+ for (size_t i = 2; i < args.size(); i++) {
+ auto value = ParseFloat(args[i]);
+ if (!value) {
+ return {Status::RedisParseErr, errValueIsNotFloat};
+ }
+ values_.push_back(*value);
+ }
+ return Status::OK();
+ }
+ Status Execute(engine::Context &ctx, Server *srv, Connection *conn,
std::string *output) override {
+ TDigest tdigest(srv->storage, conn->GetNamespace());
+ std::vector<std::string> cdf_result;
+ TDigestCDFResult result;
+ TDigestMetadata metadata;
+ auto meta_status = tdigest.GetMetaData(ctx, key_name_, &metadata);
+ if (!meta_status.ok()) {
+ if (meta_status.IsNotFound()) {
+ return {Status::RedisExecErr, errKeyNotFound};
+ }
+ return {Status::RedisExecErr, meta_status.ToString()};
+ }
+ if (metadata.total_observations == 0) {
+ *output = redis::MultiBulkString(RESP::v2, cdf_result);
+ return Status::OK();
+ }
+ auto s = tdigest.CDF(ctx, key_name_, values_, &result);
+ if (!s.ok()) {
+ return {Status::RedisExecErr, s.ToString()};
+ }
+ for (const auto &val : result.cdf_values) {
+ cdf_result.push_back(std::to_string(val));
Review Comment:
We could use `util::Float2String` as the `quantile` command.
##########
src/commands/cmd_tdigest.cc:
##########
@@ -358,7 +358,51 @@ class CommandTDigestMerge : public Commander {
std::vector<std::string> source_keys_;
TDigestMergeOptions options_;
};
+class CommandTDigestCDF : public Commander {
+ Status Parse(const std::vector<std::string> &args) override {
+ key_name_ = args[1];
+ if (args.size() == 2) return {Status::RedisParseErr,
errWrongNumOfArguments};
Review Comment:
Maybe we could check the vector size at beginning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
