PragmaTwice commented on code in PR #3053: URL: https://github.com/apache/kvrocks/pull/3053#discussion_r2276052652
########## cmake/jemalloc.cmake: ########## @@ -40,10 +40,14 @@ FetchContent_GetProperties(jemalloc) if(NOT jemalloc_POPULATED) FetchContent_Populate(jemalloc) + if(NOT DEFINED JEMALLOC_CROSS_FLAGS) + set(JEMALLOC_CROSS_FLAGS "") + endif() + Review Comment: seems useless? it is evaluated to empty if it is not defined in cmake. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
