wanghan-sanechips commented on PR #3053: URL: https://github.com/apache/kvrocks/pull/3053#issuecomment-3155479588
> Hi @wanghan-sanechips , > > The cross compile and unit test flow generally LGTM. > > We'd better adapt it to the current workflow, just like below. > > https://github.com/apache/kvrocks/blob/4450da290fe0fdaf735e222a11e6ae199cb577e6/.github/workflows/kvrocks.yaml#L218-L225 > > And the go integration test and kvrocks2redis test should also be executed in our general test flow. Once it is adapted to the matrix, it should be executed automatically. For the go client, I think we could just build an x86_64 Linux target for testing. > > Best Regards, Edward Thank you for your review and suggestions. I've implemented the changes to adapt the cross-compilation and unit test flow to the current workflow. The changes are now available in [Commit 4d893e6cf58f6a61daa267a92b7a5fcb64db298b]. Please let me know if there are any additional adjustments needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
