zhixinwen commented on PR #3047: URL: https://github.com/apache/kvrocks/pull/3047#issuecomment-3071316953
I tried to wake up WAITOF only after `auto s = util::SockSend(conn_->GetFD(), batches_bulk, conn_->GetBufferEvent());` succeeds, so that it only wake up after the data is sent to replica. But I notice it does not return error after slave is stopped.. it may be related to tcp buffer. So it is possible that the liveness check would not be able to immediately detect the slave disconnection until after it has filled in the buffer. 5 second only gives enough time for 2 liveness check, and I am increasing the wait time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
