PragmaTwice commented on code in PR #3047:
URL: https://github.com/apache/kvrocks/pull/3047#discussion_r2203761324
##########
src/server/server.h:
##########
@@ -229,6 +230,14 @@ class Server {
void WakeupBlockingConns(const std::string &key, size_t n_conns);
void OnEntryAddedToStream(const std::string &ns, const std::string &key,
const redis::StreamEntryID &entry_id);
+ // WAIT command infrastructure
+ void BlockOnWait(redis::Connection *conn, rocksdb::SequenceNumber
target_seq, uint64_t num_replicas);
+ void WakeupWaitConnections(rocksdb::SequenceNumber seq);
+ void CleanupWaitConnection(redis::Connection *conn);
+
+ // Helper methods for WAIT command
+ int GetReplicasReachedSequence(rocksdb::SequenceNumber target_seq);
Review Comment:
```suggestion
size_t GetReplicasReachedSequence(rocksdb::SequenceNumber target_seq);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
