frHimanshu commented on PR #2828: URL: https://github.com/apache/kvrocks/pull/2828#issuecomment-2745148513
Hello, @Reviewer I appreciate your thoughtful comments. You make a good point when you mention that the hash prefix in cluster mode may cause problems with key matching. ### Present Implementation: The hash prefix used in cluster mode is not currently taken into consideration by the `delprefix` command, which may result in inconsistent results when trying to match and remove keys. In order to remedy this, I suggest the following: 1. **deactivate `delprefix` in Cluster Mode:** When kvrocks is running in cluster mode 2, we can specifically deactivate the `delprefix` command to avoid irregularities. ****Future Consideration: We can investigate more reliable prefix deletion methods that appropriately manage the hash prefix in cluster mode. Before making deletions, this may require extra logic to extract and match the hash prefix. ### Next Steps: I will update the implementation to disable the `delprefix` command in cluster mode and push the changes for review. Please let me know if you have any further suggestions or if this approach seems reasonable. Thank you for your valuable input. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
