PragmaTwice commented on code in PR #2828:
URL: https://github.com/apache/kvrocks/pull/2828#discussion_r1994706811
##########
src/commands/cmd_key.cc:
##########
@@ -336,25 +336,25 @@ class CommandPersist : public Commander {
}
};
-class CommandDel : public Commander {
Review Comment:
Some problems:
- `CommandDel` cannot be removed;
- `CommandDelPrefix` should be in this file, instead of another file (if you
really build the project with your changes, I think you can find compile
errors);
- there should be some test case for this new command
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
