LindaSummer commented on code in PR #2811: URL: https://github.com/apache/kvrocks/pull/2811#discussion_r1977564664
########## src/types/redis_tdigest.cc: ########## @@ -161,6 +161,8 @@ rocksdb::Status TDigest::Add(engine::Context& ctx, const Slice& digest_name, con metadata.total_observations += inputs.size(); metadata.total_weight += inputs.size(); + metadata.maximum = std::max(metadata.maximum, *std::max_element(inputs.cbegin(), inputs.cend())); Review Comment: Hi @mapleFU , I agree on your view. 😊 Frankly this probably just because I implement the `Merge` function ahead of `Add`. 😄 So, I think move it to the `Add` function is reasonable. But we'd better remove the updating after Merge if we decide to maintain it in `Add`. Update it in two places may not be a good practice. Best Regards, Edward -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
