LindaSummer commented on code in PR #2811: URL: https://github.com/apache/kvrocks/pull/2811#discussion_r1976929785
########## src/types/redis_tdigest.cc: ########## @@ -161,6 +161,8 @@ rocksdb::Status TDigest::Add(engine::Context& ctx, const Slice& digest_name, con metadata.total_observations += inputs.size(); metadata.total_weight += inputs.size(); + metadata.maximum = std::max(metadata.maximum, *std::max_element(inputs.cbegin(), inputs.cend())); Review Comment: Hi @wyxxxcat , The `metadata.minimum` and `metadata.maximum` should represent the centroids min and max. It will be updated in [merge action](https://github.com/apache/kvrocks/blob/34007db3a5a74e7c773209a16c6d0a5cc09ef884/src/types/tdigest.cc#L238) and updated by [dumping after merging](https://github.com/apache/kvrocks/blob/34007db3a5a74e7c773209a16c6d0a5cc09ef884/src/types/tdigest.cc#L393). Maybe we could just compute inplace or create a new property in metadata to keep the consistency of metadata and centroids. 😊 If we try to do this in buffer appending, we may need to refactor the merge logic to make sure these max min properties are maintained by just one place. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
