mapleFU commented on code in PR #2803:
URL: https://github.com/apache/kvrocks/pull/2803#discussion_r1971265773
##########
src/types/redis_tdigest.cc:
##########
@@ -147,7 +147,6 @@ rocksdb::Status TDigest::Create(engine::Context& ctx, const
Slice& digest_name,
rocksdb::Status TDigest::Add(engine::Context& ctx, const Slice& digest_name,
const std::vector<double>& inputs) {
auto ns_key = AppendNamespacePrefix(digest_name);
- LockGuard guard(storage_->GetLockManager(), ns_key);
Review Comment:
May I ask the reason for not guard here?
##########
src/commands/cmd_tdigest.cc:
##########
@@ -131,6 +131,44 @@ class CommandTDigestInfo : public Commander {
std::string key_name_;
};
+class CommandTDigestAdd : public Commander {
+ public:
+ Status Parse(const std::vector<std::string> &args) override {
+ key_name_ = args[1];
+
+ values_.reserve(args.size());
Review Comment:
args.size() - 2?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
