PragmaTwice commented on code in PR #2803:
URL: https://github.com/apache/kvrocks/pull/2803#discussion_r1970807653
##########
src/commands/cmd_tdigest.cc:
##########
@@ -131,6 +131,44 @@ class CommandTDigestInfo : public Commander {
std::string key_name_;
};
+class CommandTDigestAdd : public Commander {
+ public:
+ Status Parse(const std::vector<std::string> &args) override {
+ key_name_ = args[1];
+ values_.reserve(args.size());
+
+ for (size_t i = 2; i < args.size(); i++) {
+ auto value = ParseFloat<>(args[i]);
Review Comment:
```suggestion
auto value = ParseFloat(args[i]);
```
I prefer to remove this `<>`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
