[
https://issues.apache.org/jira/browse/IGNITE-9023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16709833#comment-16709833
]
Vyacheslav Daradur commented on IGNITE-9023:
--------------------------------------------
[~DmitriyGovorukhin], thank you for the review!
Regarding your questions:
bq. Why do you use a custom topic? Can we do a test with standard P2P topic?
Custom topic has been used to test explicit behaviour, and to be sure that we
received the response as a reaction on our broken request. If we use P2P topic
our test may be affected by environment and other internal modules during
Ignite's lifecycle.
bq. Why test was added in kernel test suite but not in p2p?
I thought in this way:
1. The test is related to deployment infrastructure more than to testing of p2p
behaviour;
2. {{GridDeploymentCommunication}} affected by changes is used in
{{GridDeploymentManager}} which is part of kernal;
3. In test we use {{GridDeploymentRequest}} and {{GridDeploymentResponse}}
which have package private access, so we had to use
{{org.apache.ignite.internal.managers.deployment}} package for test and other
tests in the package have been placed in {{IgniteKernalSelfTestSuite}}.
If you think that the test is more suitable to be placed in a different
test-suite, please let me know, I will fix this quickly.
I've fixed all your notes, please, have a look.
Thanks in advance!
> LinkageError or ClassNotFoundException should not be swollen by
> GridDeploymentCommunication during processing deployment request.
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: IGNITE-9023
> URL: https://issues.apache.org/jira/browse/IGNITE-9023
> Project: Ignite
> Issue Type: Improvement
> Affects Versions: 2.5
> Reporter: Ivan Daschinskiy
> Assignee: Vyacheslav Daradur
> Priority: Minor
> Fix For: 2.8
>
>
> In current implementation any error, that is thrown in
> GridDeploymentCommunication#processResourceRequest, is ignored silently.
> Any error should be logged and send to client.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
