[
https://issues.apache.org/jira/browse/IGNITE-9023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16698236#comment-16698236
]
Vyacheslav Daradur commented on IGNITE-9023:
--------------------------------------------
I reassigned the issue myself because there is no answer from Ruchir.
I researched the issue, summary: we can't just respond with an error in case of
{{LinkageError}} or {{ClassNotFoundException}} because resource name is able
not to be class name and we should try to load it from resources. (this
behavior is covered by {{IgniteExplicitImplicitDeploymentSelfTest}})
So, I added {{LinkageError}} to catch block with the corresponding comment,
also logging was added.
Test to check logging and receiving of response in case of an error also has
been added.
Tests look good, the inspection failure doesn't relate to the PR.
[~ivandasch], could you review the prepared solution, please?
> LinkageError or ClassNotFoundException should not be swollen by
> GridDeploymentCommunication during processing deployment request.
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: IGNITE-9023
> URL: https://issues.apache.org/jira/browse/IGNITE-9023
> Project: Ignite
> Issue Type: Improvement
> Affects Versions: 2.5
> Reporter: Ivan Daschinskiy
> Assignee: ruchir choudhry
> Priority: Minor
> Fix For: 2.8
>
>
> In current implementation any error, that is thrown in
> GridDeploymentCommunication#processResourceRequest, is ignored silently.
> Any error should be logged and send to client.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
