[
https://issues.apache.org/jira/browse/IGNITE-10275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16691660#comment-16691660
]
ASF GitHub Bot commented on IGNITE-10275:
-----------------------------------------
SomeFire commented on a change in pull request #74: IGNITE-10275 Refactor of
visa caching. Jira spam fix.
URL: https://github.com/apache/ignite-teamcity-bot/pull/74#discussion_r234602866
##########
File path:
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/web/model/ContributionKey.java
##########
@@ -17,23 +17,32 @@
package org.apache.ignite.ci.web.model;
+import org.apache.ignite.ci.teamcity.ignited.IStringCompactor;
+
/**
*
*/
public class ContributionKey {
/** */
public final String srvId;
- /** */
- public final String ticket;
-
/** */
public final String branchForTc;
/** */
- public ContributionKey(String srvId, String ticket, String branchForTc) {
+ public ContributionKey(String srvId, String branchForTc) {
this.branchForTc = branchForTc;
this.srvId = srvId;
- this.ticket = ticket;
+ }
+
+ /** */
+ public ContributionKey(CompactContributionKey key, IStringCompactor
strCompactor) {
+ this.branchForTc = strCompactor.getStringFromId(key.branchForTc);
+ this.srvId = strCompactor.getStringFromId(key.srvId);
+ }
+
+ /** */
Review comment:
```suggestion
/** {@inheritDoc} */
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [TC Bot] Several JIRA comments are issued in case ignite.cache.remove failed
> ----------------------------------------------------------------------------
>
> Key: IGNITE-10275
> URL: https://issues.apache.org/jira/browse/IGNITE-10275
> Project: Ignite
> Issue Type: Task
> Reporter: Dmitriy Pavlov
> Assignee: PetrovMikhail
> Priority: Major
>
> Examples of spam:
> - https://issues.apache.org/jira/browse/IGNITE-9308
> - https://issues.apache.org/jira/browse/IGNITE-10141
> org/apache/ignite/ci/observer/ObserverTask.java:179
> org.apache.ignite.IgniteCache#remove(K)
> returns false, so bot tries to re-comment ticket in next cycle.
> It is possible as a fast fix at first check removes result, as a full fix we
> can refactor visa requests queue to some new (probably synthetic key).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
