[
https://issues.apache.org/jira/browse/IGNITE-10275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16691661#comment-16691661
]
ASF GitHub Bot commented on IGNITE-10275:
-----------------------------------------
SomeFire commented on a change in pull request #74: IGNITE-10275 Refactor of
visa caching. Jira spam fix.
URL: https://github.com/apache/ignite-teamcity-bot/pull/74#discussion_r234600605
##########
File path:
ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/observer/BuildObserver.java
##########
@@ -69,28 +93,27 @@ public void stop() {
public void observe(String srvId, ICredentialsProv prov, String ticket,
String branchForTc, Build... builds) {
BuildsInfo buildsInfo = new BuildsInfo(srvId, prov, ticket,
branchForTc, builds);
- visasStorage.put(new VisaRequest(buildsInfo));
-
observerTask.addInfo(buildsInfo);
}
/**
* @param srvId Server id.
* @param branch Branch.
*/
- public String getObservationStatus(String srvId, String branch) {
+ public String getObservationStatus(ContributionKey key) {
Review comment:
Update javadocs too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [TC Bot] Several JIRA comments are issued in case ignite.cache.remove failed
> ----------------------------------------------------------------------------
>
> Key: IGNITE-10275
> URL: https://issues.apache.org/jira/browse/IGNITE-10275
> Project: Ignite
> Issue Type: Task
> Reporter: Dmitriy Pavlov
> Assignee: PetrovMikhail
> Priority: Major
>
> Examples of spam:
> - https://issues.apache.org/jira/browse/IGNITE-9308
> - https://issues.apache.org/jira/browse/IGNITE-10141
> org/apache/ignite/ci/observer/ObserverTask.java:179
> org.apache.ignite.IgniteCache#remove(K)
> returns false, so bot tries to re-comment ticket in next cycle.
> It is possible as a fast fix at first check removes result, as a full fix we
> can refactor visa requests queue to some new (probably synthetic key).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
