[ 
https://issues.apache.org/jira/browse/IGNITE-8737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535062#comment-16535062
 ] 

Sergey Chugunov commented on IGNITE-8737:
-----------------------------------------

[~Mmuzaf],

Thanks for spotting this! 

It seems we missed a case when lastEntry may be empty. We may choose here from 
two options: 
* Check if histMap is empty inside *onCheckpointFinished*. If it is just don't 
log anything (it was the very first checkpoint).
* Check in caller that there is no history, calculate necessary index in caller 
and pass it to *onCheckpointFinished* to prepare correct log message.

Could you please file a ticket for this and prepare a pull request?

> Improve checkpoint logging information
> --------------------------------------
>
>                 Key: IGNITE-8737
>                 URL: https://issues.apache.org/jira/browse/IGNITE-8737
>             Project: Ignite
>          Issue Type: Improvement
>            Reporter: Alexey Goncharuk
>            Assignee: Andrew Medvedev
>            Priority: Major
>             Fix For: 2.7
>
>
> 1) Move to INFO log rollover and log archivation events
> 2) Make sure log rollover and archive errors are logged
> 3) When checkpoint finishes, we need to print out which segments were fully 
> covered by this checkpoint in the "Checkpoint finished ..." message



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to