[
https://issues.apache.org/jira/browse/IGNITE-8737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16515736#comment-16515736
]
Alexey Goncharuk commented on IGNITE-8737:
------------------------------------------
[~andmed], I do not agree with the fix. You've added the output for the
segments that are cleared by the checkpointer, however we need output for
segments that were fully covered by this checkpoint.
In other words, if there was a checkpoint A with WAL Pointer = [10, 1234], and
there was another checkpoint B with WAL Pointer = [15, 2345], then closing
checkpoint B should print out segments [10, 11, 12, 13, 14] because they are no
longer needed for crash recovery. Note that segment 15 is still required.
Also, a few comments regarding the code: I do not think having method argument
as a return type is a good style, please change the return type of the method
to return an object. The interface is a private API and we can freely change it.
> Improve checkpoint logging information
> --------------------------------------
>
> Key: IGNITE-8737
> URL: https://issues.apache.org/jira/browse/IGNITE-8737
> Project: Ignite
> Issue Type: Improvement
> Reporter: Alexey Goncharuk
> Assignee: Andrew Medvedev
> Priority: Major
> Fix For: 2.6
>
>
> 1) Move to INFO log rollover and log archivation events
> 2) Make sure log rollover and archive errors are logged
> 3) When checkpoint finishes, we need to print out which segments were fully
> covered by this checkpoint in the "Checkpoint finished ..." message
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
