[
https://issues.apache.org/jira/browse/IGNITE-2294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15663774#comment-15663774
]
Vladimir Ozerov commented on IGNITE-2294:
-----------------------------------------
Alex, my comments on all change except of deep SQL-related stuff:
1) {{ignite-clients}} - tests are not included into suite, so they will not run
on TC
2) {{ignite-yardstick}} - looks like there are way too much benchmarks. I doubt
we will really ever run them. At the very least, let's move them from {{cache}}
package to {{dml}} package.
3) {{QueryEntity}} is {{Serializable}}. We add a field to it, so compatibility
could be broken.
4) {{X.defaultPrimitiveValue}}, {{X.DEFAULTS}} - unused code
5) {{X.ensureX}} - this method concerns me a lot. First, it appears that you
use it to check internal conditions in some places. Assertions should be used
instead. Second, it leads to invalid exception chains in some other places.
E.g. {{GridSqlStatementSplitter.splitUpdateQuery}} - if you throw
{{IgniteCheckedException}} from there, then it will be caught by catch block in
{{IgniteH2Indexing.queryTwoStep0}}, what will result in the following exception
chain which is very hard to understand:
{code}
"Failed to bind parameters ..." caused by "Failed to retrieve target for SQL
update operation".
{code}
6) Several class have unused imports.
7) {{PlatformConfigurationUtils}} - you read key fields, but I do not see
relevant code in .NET and CPP classes. It means, that quering is broken for
platforms. This change should be reverted.
8) {{CacheObjectBinaryProcessor.registerType}} - unused method.
9) {{JdbcQueryTask}}, {{QueryResult}} - new field which breaks compatibility
contract.
10) Tests in "indexing" module: not added to any suite. Probably they should be
in {{IgniteCacheQuerySelfTestSuite}}.
11) Tests in "indexing" module: no need to duplicate them for binary and
optimized marshallers. It is already handled by
{{IgniteCacheQuerySelfTestSuite}} and {{IgniteBinaryCacheQueryTestSuite}}
classes.
> Implement SQL DML (insert, update, delete) clauses.
> ---------------------------------------------------
>
> Key: IGNITE-2294
> URL: https://issues.apache.org/jira/browse/IGNITE-2294
> Project: Ignite
> Issue Type: Wish
> Reporter: Sergi Vladykin
> Assignee: Alexander Paschenko
> Labels: important
> Fix For: 1.8
>
>
> We need to add parsing for all the listed SQL commands and translate them
> into respective cache operations (putIfAbstent, put, remove).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
