[
https://issues.apache.org/jira/browse/IGNITE-26708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18100804#comment-18100804
]
Anton Vinogradov commented on IGNITE-26708:
-------------------------------------------
There are two open PRs on this ticket:
* [#12421|https://github.com/apache/ignite/pull/12421] - "Revise
TcpDiscoveryMetricsUpdateMessage - test", open since February;
* [#12788|https://github.com/apache/ignite/pull/12788] - "no disco metrics v2",
open since April.
Vladislav, which one should be reviewed? Please close the other one, so the
ticket has a single patch.
Also, the ticket got fixVersion 2.19 as part of a rolling upgrade triage:
TcpDiscoveryMetricsUpdateMessage is on the wire, so a change to it has to be
merged before 2.19 is released.
> Revise TcpDiscoveryMetricsUpdateMessage
> ---------------------------------------
>
> Key: IGNITE-26708
> URL: https://issues.apache.org/jira/browse/IGNITE-26708
> Project: Ignite
> Issue Type: Improvement
> Reporter: Vladimir Steshin
> Priority: Minor
> Labels: IEP-132, discovery, ise, wire-format
> Fix For: 2.19
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> We have _TcpDiscoveryMetricsUpdateMessage_ and related
> {_}EVT_NODE_METRICS_UPDATED{_}. And also similar
> _ClusterMetricsUpdateMessage_ in {_}Communication{_}. Both of them send the
> metrics. If discovery is not of _TPC_ type (ZooKeeper for instance), then the
> metrics are sent through {_}Communication{_}:
> {code:java}
> ClusterProcessor:
> sndMetrics = !(ctx.config().getDiscoverySpi() instanceof TcpDiscoverySpi);
> if (sndMetrics) {
> metricsProvider = ctx.discovery().createMetricsProvider();
> long updateFreq = ctx.config().getMetricsUpdateFrequency();
> ctx.timeout().addTimeoutObject(new
> MetricsUpdateTimeoutObject(updateFreq));
> } {code}
>
> Why not sending the metrics via _Communication_ only? Pros: fewer discovery
> messages; no duplication of functionality, messages and serialization; more
> lightweight discovery.
> No need of delivery guarantee here.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
