[
https://issues.apache.org/jira/browse/IGNITE-28872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18097092#comment-18097092
]
Ignite TC Bot commented on IGNITE-28872:
----------------------------------------
Docs Required cleared. The required documentation update is already included in
merged PR #13369 / commit 9e3e58ef67: docs/_docs/tools/control-script.adoc and
docs/_docs/configuring-caches/partition-loss-policy.adoc cover
reset_lost_partitions usage and the baseline-owner precondition. No separate
documentation follow-up is needed.
> Incorrect help text for control.sh --cache reset_lost_partitions
> ----------------------------------------------------------------
>
> Key: IGNITE-28872
> URL: https://issues.apache.org/jira/browse/IGNITE-28872
> Project: Ignite
> Issue Type: Bug
> Reporter: Aleksandr Chesnokov
> Assignee: Aleksandr Chesnokov
> Priority: Major
> Labels: documentation, ise
> Fix For: 2.19
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> help for control.(sh|bat) says that reset_lost_partitions uses cache names:
>
> {noformat}
> control.(sh|bat) --cache reset_lost_partitions cacheName1,...,cacheNameN
> {noformat}
> But the command works with cache group names. In the code, the argument is
> used as a cache group name. The command searches a cache group and then
> resets lost partitions for all caches in this group.
> This can confuse users. A user can pass a cache name from the help, but the
> command expects a cache group name.
> Let's update the help text for control.(sh|bat) --cache reset_lost_partitions.
> Change:
> {noformat}
> Reset the state of lost partitions for the specified caches{noformat}
> to smth like
> {noformat}
> Reset the state of lost partitions for the specified cache groups{noformat}
> Change the example:
> {noformat}
> control.(sh|bat) --cache reset_lost_partitions cacheName1,...,cacheNameN
> {noformat}
> to:
> {noformat}
> control.(sh|bat) --cache reset_lost_partitions
> groupName1,...,groupNameN{noformat}
> Also update related documentation and expected help output tests
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
