[ 
https://issues.apache.org/jira/browse/IGNITE-28872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18096253#comment-18096253
 ] 

Ignite TC Bot commented on IGNITE-28872:
----------------------------------------

{panel:title=Branch: [pull/13369/head] Base: [master] : No blockers 
found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
{panel:title=Branch: [pull/13369/head] Base: [master] : New Tests 
(1)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}
{color:#00008b}Calcite SQL 2{color} [[tests 
1|https://ci2.ignite.apache.org/viewLog.html?buildId=9208332]]
* {color:#013220}IgniteCalciteTestSuite2: 
DataTypesPlannerTest.testLiteralToUuidConversion - PASSED{color}

{panel}
[TeamCity *--> Run :: All* 
Results|https://ci2.ignite.apache.org/viewLog.html?buildId=9208366&buildTypeId=IgniteTests24Java8_RunAll]
{color:#ffffff}tcbot-analysis-comment chainBuildId=9208366 
rerunBuildIds=9209135,9209137,9209139{color}

> Incorrect help text for control.sh --cache reset_lost_partitions
> ----------------------------------------------------------------
>
>                 Key: IGNITE-28872
>                 URL: https://issues.apache.org/jira/browse/IGNITE-28872
>             Project: Ignite
>          Issue Type: Bug
>            Reporter: Aleksandr Chesnokov
>            Assignee: Aleksandr Chesnokov
>            Priority: Major
>              Labels: docuentation, ise
>             Fix For: 2.19
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> help for control.(sh|bat) says that reset_lost_partitions uses cache names:
>  
> {noformat}
> control.(sh|bat) --cache reset_lost_partitions cacheName1,...,cacheNameN
> {noformat}
> But the command works with cache group names. In the code, the argument is 
> used as a cache group name. The command searches a cache group and then 
> resets lost partitions for all caches in this group.
> This can confuse users. A user can pass a cache name from the help, but the 
> command expects a cache group name.
> Let's update the help text for control.(sh|bat) --cache reset_lost_partitions.
> Change:
> {noformat}
> Reset the state of lost partitions for the specified caches{noformat}
> to smth like
> {noformat}
> Reset the state of lost partitions for the specified cache groups{noformat}
> Change the example:
> {noformat}
> control.(sh|bat) --cache reset_lost_partitions cacheName1,...,cacheNameN
> {noformat}
> to:
> {noformat}
> control.(sh|bat) --cache reset_lost_partitions 
> groupName1,...,groupNameN{noformat}
> Also update related documentation and expected help output tests



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to