imbajin commented on code in PR #3138:
URL: https://github.com/apache/hugegraph/pull/3138#discussion_r3763406259
##########
hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/core/GraphManager.java:
##########
@@ -1342,19 +1350,38 @@ public HugeGraph createGraph(String graphSpace, String
name, String creator,
graph.updateTime(timeStamp);
String graphName = spaceGraphName(graphSpace, name);
+ this.graphs.put(graphName, graph);
Review Comment:
@bitflicker64 Confirmed. This is a real follow-up gap: after local
GRAPH_CREATE succeeds, a failure in PD metadata publication or schema
initialization can still leave local graph/bindings and partially written
metadata behind.
For the current PR, we are keeping this outside the minimal Phase 1 boundary
(the creating Server's local bindings must be ready before 200). Please track
it under [#3137](https://github.com/apache/hugegraph/issues/3137) as the Phase
3 graph-creation state-machine work, including compensating metadata cleanup
and one rollback boundary across publication/schema initialization.
Marking this as a follow-up for now; I am leaving the thread unresolved
until that work is addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
