bitflicker64 commented on PR #3138: URL: https://github.com/apache/hugegraph/pull/3138#issuecomment-5177443746
Both points addressed in 9a4ac02e, details in the inline replies. Two things left out on purpose: - The PD drop path (`GraphManager.java:2153`) still fires `GRAPH_DROP` without waiting, and passes the graph after `close()`. Same class of bug, pre-existing, on the drop side. Glad to fold it in if you want create and drop symmetric here. - Creation is still publish-then-finish overall, since `prepareSchema` runs after the config is in meta. That is the rollback risk in #3137 that phase 3 is meant to close. There is no automated coverage for the new failure semantics: nothing exercises `notifyAndWaitEvent` today, and the race itself needs a multi-server deployment. A unit test registering a deliberately throwing listener on a scratch `EventHub` would cover the count check and the cleanup cheaply, if you want it here. `codecov/project` looks like a base-report artifact: it reports +11 files and +1150 lines against base, which this diff cannot produce, while `codecov/patch` passes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
