bitflicker64 commented on PR #3119: URL: https://github.com/apache/hugegraph/pull/3119#issuecomment-5155653907
Both Copilot points, one taken and one deferred. **README (taken, ff1325a).** Correct catch, and it was my own stale text. After the marker moved into `init-store`, the paragraph still described the entrypoint owning it and still claimed the mounted-property case was unguarded — which is exactly what that change removed. It now says the marker is written by init-store only after it has initialized, so a skipped run records nothing whichever way it was disabled. **`set_prop` separators (deferred to #3133).** The behaviour is real: `set_prop` detects only `key=`, so a mounted `rest-server.properties` using `:` gets a second logical definition appended and `HugeConfig` then rejects the file as a list — `testDuplicateDefinitionFailsToLoad` pins that symptom. Leaving it here for three reasons. It is pre-existing and not specific to this option: the same `set_prop` already maps `backend` and `pd.peers`, so any fix should cover all three at once. It fails closed and loudly rather than silently, now that init-store propagates its exit status — the container stops instead of starting misconfigured. And teaching shell to match `=`, `:` and whitespace separators is the start of a properties parser in `sed`, which was rejected on this PR earlier for not matching the grammar `HugeConfig` actually uses. That is the same reasoning behind moving `ConfigTool` out, and #3133 covers replacing `grep`/`sed` property access with the Commons Configuration path. I have added the separator case there explicitly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
