bitflicker64 commented on PR #3119: URL: https://github.com/apache/hugegraph/pull/3119#issuecomment-5152672373
Rescoped this PR. It had grown to ~2,900 lines doing two unrelated things: the init-store gate #3118 asked for, and a rewrite of the Docker auth bootstrap built on a new `ConfigTool`. Reviewing those as one diff was not reasonable, so the second half is now #3133 and follows as its own PR. What is left here is 496 lines across 7 files — the option, the gate, the env mapping, and the init-flag guard. Your 7 open threads are all on code that moved out. I have replied on each pointing at #3133 instead of resolving them, so they stay findable there. Two things worth flagging from re-reading it: - `bin/init-store.sh` always exited `0`, because of the trailing `echo "Initialization finished."`. So the fail-closed check this PR adds was never observable — the entrypoint started the server regardless. Fixed here, which is what makes the check mean anything. - `PASSWORD` does nothing when init-store is skipped. `init-store` reads it from stdin and the disabled path returns before that, so the admin is created from `auth.admin_pa`, whose default `pa` is public. Documented in `docker/README.md` and warned at runtime; the real fix needs #3133. The admin-bootstrap check no longer requires `auth.admin_pa` — nothing in the container writes it, so that clause could never be satisfied and would have broken the distributed path once the exit status started propagating. `usePD` and the HStore auth-graph checks stay, which is what your original comment was about. 604 tests, 0 failures on JDK 11, checkstyle clean. Description updated to match. Not run: `shellcheck` (unavailable locally) and no end-to-end container build — the entrypoint changes are verified by extracted-script simulation, not a running container. Mirrored to https://github.com/hugegraph/hugegraph/pull/171. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
