bitflicker64 commented on PR #3126: URL: https://github.com/apache/hugegraph/pull/3126#issuecomment-5155561632
Follow-up review found two issues in my own earlier commit, both fixed in 9438a943: 1. **The JDK 24+ guard could be defeated by an env var.** `java -version` prints `Picked up JAVA_TOOL_OPTIONS: ...` before the version line whenever `JAVA_TOOL_OPTIONS`/`_JAVA_OPTIONS` is set, so the existing `head -1` parse left `JAVA_VERSION` unusable and every version-gated branch silently evaluated false — the new guard never fired, and `-Djava.security.manager=allow` was dropped on JDK 18-23. Now the version line is selected explicitly and a non-numeric result is rejected. 2. **A missing `conf/java-security.properties` failed with the reason in the wrong log.** The bootstrap's stderr goes to `hugegraph-server-stdout.log` in daemon mode, while `start-hugegraph.sh` points operators at `hugegraph-server.log`. The launcher now names the missing file in that log. Both are covered by new regression tests, and each was confirmed non-vacuous by reverting the fix and checking the test fails. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
