bitflicker64 commented on code in PR #3126:
URL: https://github.com/apache/hugegraph/pull/3126#discussion_r3677430266
##########
.github/workflows/server-ci.yml:
##########
@@ -89,6 +89,7 @@ jobs:
mvn package -Dmaven.test.skip=true -pl
hugegraph-server/hugegraph-dist -am -ntp
VERSION=$(mvn help:evaluate -Dexpression=project.version -q
-DforceStdout)
SERVER_DIR=hugegraph-server/apache-hugegraph-server-$VERSION/
+ $TRAVIS_DIR/test-java-security-properties.sh $SERVER_DIR
Review Comment:
Fixed in 35e1a240. The Java security-properties test now runs in its own
RocksDB step after packaging and is independent of the `lsof`, `crontab`, and
`curl` startup preflight. Only `test-start-hugegraph.sh` remains behind that
broader prerequisite gate.
##########
hugegraph-server/hugegraph-dist/src/assembly/static/bin/hugegraph-server.sh:
##########
@@ -143,7 +143,9 @@ esac
JVM_OPTIONS="-Dlog4j.configurationFile=${CONF}/log4j2.xml"
if [[ ${OPEN_SECURITY_CHECK} == "true" ]]; then
- JVM_OPTIONS="${JVM_OPTIONS}
-Djava.security.manager=org.apache.hugegraph.security.HugeSecurityManager"
+ JVM_OPTIONS="${JVM_OPTIONS} \
+ -Djava.security.properties=${CONF}/java-security.properties \
Review Comment:
Fixed in 35e1a240. With security enabled, the launcher now rejects a
missing, unreadable, or non-file bundled properties path unless the effective
last later `-Djava.security.properties=...` override has a non-empty value. The
focused regression covers the missing path, non-file path, empty override,
valid-then-empty rejection, empty-then-valid acceptance, and restoration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
