bitflicker64 commented on PR #3105: URL: https://github.com/apache/hugegraph/pull/3105#issuecomment-5083059763
### Status since imbajin’s last review Addressing the blocking items from the later review rounds (including heads `9fdc941d` / `1f3f01e5` / `9b60fbb4`). Current tip: **`986c95f1`**. **Port check correctness** - Fixed: listener matching is endpoint-based (not bare port-only); hostname → numeric resolution before `ss`/`netstat` compare - Fixed: IPv6 canonicalization via `normalize_addr()` (compressed vs expanded, brackets, zone scope, IPv4-mapped) - Fixed: same-family wildcard conflicts only (IPv4 `0.0.0.0` / IPv6 `::` isolated) - Fixed: tool failure fallthrough — nonzero `ss`/`netstat` does not count as “port free”; falls through to next probe - Fixed: `/dev/tcp` bounded with `timeout` or `run_with_deadline()` (no open-ended hang) - Fixed: `run_with_deadline` arg order `(cmd, deadline, args…)` — wrong order that printed `8080|2` is fixed - Fixed: `/dev/tcp` host/port passed as `"$1"`/`"$2"` (no shell reparse of config text) **URL / authority parsing** - Fixed: authority cut at first `/`, `?`, or `#` (query/fragment no longer poisons port) - Fixed: bracket IPv6 forms (`[::1]:8080` and scheme-less variants) - Fixed: whitespace stripping on URL/host; octal-safe port via `$((10#port))` **download() / PD–Store** - Fixed: atomic download (temp + `mv` on success, `rm` on failure) — no partial-file poison - Fixed: `curl -fL`, correct `-o` before `--`; wget progress as Bash 3.2-safe array - Fixed: dead `check_port` removed from PD/Store; `command_available` inversion fixed **CI / tests / cleanup** - Fixed: `test-check-port.sh` — 40 mock-driven tests (ss / netstat / `/dev/tcp` / IPv6 / download / no-timeout watchdog) - Fixed: no-timeout watchdog exercised; `local` outside function removed - Fixed: EXIT trap registered early so Python child / temp file cleanup runs on `exit 1` path - Fixed: PD/Store/Server start tests — `fuser` preflight on Linux, OS-aware cleanup, `STOP_SCRIPT` before kill - Fixed: accidental revert of #3100 count-optm fix — branch now includes master (merge with #3102) **Also** - `process_num` / `process_id` no longer use truncated exit codes for PIDs/counts - Darwin `free_memory` empty-value guards - Server `read_property` / `ensure_package_exist` polish aligned with PD/Store Local: `bash -n` clean; `test-check-port.sh` → **40 passed, 0 failed**. Happy to take another look when you have time — thanks for the thorough reviews. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
